Add support for EKS Capability #45326

punkwalker · 2025-12-01T06:57:53Z

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds support for managing EKS Capabilities - https://docs.aws.amazon.com/eks/latest/userguide/capabilities.html

Relations

Closes #45324

References

Output from Acceptance Testing

make testacc TESTS=TestAccEKSCapability PKG=eks

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_eks_capability 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCapability'  -timeout 360m -vet=off
2025/12/01 06:59:51 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 06:59:51 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEKSCapability_basic
=== PAUSE TestAccEKSCapability_basic
=== RUN   TestAccEKSCapability_disappears
=== PAUSE TestAccEKSCapability_disappears
=== RUN   TestAccEKSCapability_tags
=== PAUSE TestAccEKSCapability_tags
=== CONT  TestAccEKSCapability_basic
=== CONT  TestAccEKSCapability_tags
=== CONT  TestAccEKSCapability_disappears
--- PASS: TestAccEKSCapability_basic (685.28s)
--- PASS: TestAccEKSCapability_disappears (726.03s)
--- PASS: TestAccEKSCapability_tags (745.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        745.598s
...

Signed-off-by: Pankaj Walke <[email protected]>

github-actions · 2025-12-01T06:58:07Z

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

github-actions · 2025-12-01T06:58:09Z

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
Please see our prioritization guide for additional information on how the maintainers handle prioritization.
Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…tion.

% make testacc TESTARGS='-run=TestAccEKSCapability_' PKG=eks make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 HEAD 🌿... TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSCapability_ -timeout 360m -vet=off 2025/12/01 15:00:37 Creating Terraform AWS Provider (SDKv2-style)... 2025/12/01 15:00:37 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccEKSCapability_basic === PAUSE TestAccEKSCapability_basic === RUN TestAccEKSCapability_disappears === PAUSE TestAccEKSCapability_disappears === RUN TestAccEKSCapability_tags === PAUSE TestAccEKSCapability_tags === CONT TestAccEKSCapability_basic === CONT TestAccEKSCapability_tags === CONT TestAccEKSCapability_disappears --- PASS: TestAccEKSCapability_disappears (730.41s) --- PASS: TestAccEKSCapability_tags (736.61s) --- PASS: TestAccEKSCapability_basic (755.84s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 761.264s

github-actions · 2025-12-01T20:44:25Z

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

…egin with '% '".

% make testacc TESTARGS='-run=TestAccEKSCapability_argoCD' PKG=eks make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 HEAD 🌿... TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSCapability_argoCD -timeout 360m -vet=off 2025/12/01 17:12:27 Creating Terraform AWS Provider (SDKv2-style)... 2025/12/01 17:12:27 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccEKSCapability_argoCD === PAUSE TestAccEKSCapability_argoCD === CONT TestAccEKSCapability_argoCD --- PASS: TestAccEKSCapability_argoCD (914.69s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 920.195s

This is a valid use of `append` without re-assigning the result to the first argument.

…nv var Test still failing, but no longer due to server side validation of the IDC group identifier. ```console % WS_IDENTITY_STORE_USER_ID=c4b86468-0061-702e-f540-d17f8b3bc6f1 AWS_IDENTITY_STORE_GROUP_NAME=f48884f8-30e1-7057-0c44-848c0aca4ed2 make t K=eks T=TestAccEKSCapability_ArgoCD_rbac make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_eks_capability 🌿... TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCapability_ArgoCD_rbac' -timeout 360m -vet=off 2025/12/02 13:47:51 Creating Terraform AWS Provider (SDKv2-style)... 2025/12/02 13:47:51 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccEKSCapability_ArgoCD_rbac === PAUSE TestAccEKSCapability_ArgoCD_rbac === CONT TestAccEKSCapability_ArgoCD_rbac capability_test.go:217: Step 3/3 error: Error running apply: exit status 1 Error: Invalid list/set with aws_eks_capability.test, on terraform_plugin_test.tf line 119, in resource "aws_eks_capability" "test": 119: resource "aws_eks_capability" "test" { too many elements: want 1, got 2 --- FAIL: TestAccEKSCapability_ArgoCD_rbac (1104.26s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/eks 1110.774s ```

ewbankkit

LGTM 🚀.

% AWS_IDENTITY_STORE_USER_ID=926776f3c6-53ea24ec-f8f8-4e7c-a015-d238f4ec12fb AWS_IDENTITY_STORE_GROUP_ID=926776f3c6-71733eb8-b181-488e-8ed6-17b07e79380e make testacc TESTARGS='-run=TestAccEKSCapability_ArgoCD_' PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSCapability_ArgoCD_ -timeout 360m -vet=off
2025/12/02 16:21:53 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/02 16:21:53 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEKSCapability_ArgoCD_basic
=== PAUSE TestAccEKSCapability_ArgoCD_basic
=== RUN   TestAccEKSCapability_ArgoCD_rbac
=== PAUSE TestAccEKSCapability_ArgoCD_rbac
=== CONT  TestAccEKSCapability_ArgoCD_basic
=== CONT  TestAccEKSCapability_ArgoCD_rbac
--- PASS: TestAccEKSCapability_ArgoCD_rbac (1021.30s)
--- PASS: TestAccEKSCapability_ArgoCD_basic (1114.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1121.572s

website/docs/r/eks_capability.html.markdown

internal/service/eks/capability_test.go

Co-authored-by: Jared Baker <[email protected]>

punkwalker added 3 commits December 1, 2025 06:42

Initial changes for supporting EKS Capability

177f163

Signed-off-by: Pankaj Walke <[email protected]>

use public SDK release

5f9f000

update go.mod and go.sum

c992f1b

punkwalker requested a review from a team as a code owner December 1, 2025 06:57

punkwalker added 2 commits December 1, 2025 07:16

add changelog entry

612560c

remove go dependency changes

53fccf2

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 1, 2025

ewbankkit self-assigned this Dec 1, 2025

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 1, 2025

ewbankkit added 10 commits December 1, 2025 08:43

Merge commit '9b36407fafa2094edc842fcff478cb5da93b69d9' into HEAD

cb800c6

r/aws_eks_capability: Terraform Plugin Framework implementation.

872cc34

r/aws_eks_capability: Switch to Terraform Plugin Framework implementa…

38e11de

…tion.

r/aws_eks_capability: Update documentation.

4327cc6

r/aws_eks_capability: Initial acceptance tests.

9e13d9f

r/aws_eks_capability: Remove Terraform Plugin SDK implementation.

1895d18

Correct source file name.

4a6747b

eks: Tidy up finders.

2912d6e

r/aws_eks_capability: Better error reporting.

6fa6b5c

Merge branch 'main' into HEAD

c84723e

ewbankkit added 8 commits December 1, 2025 15:47

Fix terrafmt errors.

1b5b398

Fix documentation subcategory.

440ecc4

Fix tdproviderdocs "import section code block type 'console' should b…

4c05dbf

…egin with '% '".

Add 'TestAccEKSCapability_argoCD'.

fccf2fc

Add 'TestAccEKSCapability_ArgoCD_rbac'.

a8397c2

Standardize acceptance testing Identity Store user and group handling.

787af24

TestAccEKSCapability_ArgoCD_rbac: Use standard environment variables.

ec2c4ee

github-actions bot added service/emr Issues and PRs that pertain to the emr service. service/kendra Issues and PRs that pertain to the kendra service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. labels Dec 2, 2025

jar-b and others added 6 commits December 2, 2025 13:59

r/aws_eks_capability: fix gocritic linter finding

82b53fa

This is a valid use of `append` without re-assigning the result to the first argument.

docs: document AWS_IDENTITY_STORE_GROUP_ID acctest variable

4851f27

r/aws_ssoadmin_account_assignment: Use 'AWS_IDENTITY_STORE_USER_NAME'.

7cb65c6

r/aws_eks_capability: Add 'configuration.argo_cd.server_url' attribute.

725b9fc

Ignore 'RbacRoleMappings' for AutoFlEx during update.

d1a6f00

ewbankkit previously approved these changes Dec 2, 2025

View reviewed changes

jar-b reviewed Dec 2, 2025

View reviewed changes

website/docs/r/eks_capability.html.markdown Outdated Show resolved Hide resolved

internal/service/eks/capability_test.go Show resolved Hide resolved

Update website/docs/r/eks_capability.html.markdown

7a57a35

Co-authored-by: Jared Baker <[email protected]>

ewbankkit dismissed their stale review via 7a57a35 December 2, 2025 21:59

ewbankkit added 3 commits December 2, 2025 17:45

Normalize.

4e2b376

Merge commit '4e2b376ee156774c1cfa98163bb87170cb99183a' into HEAD

03bcbad

Merge branch 'main' into HEAD

1a2f3af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for EKS Capability #45326

Add support for EKS Capability #45326

punkwalker commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

ewbankkit left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add support for EKS Capability #45326

Are you sure you want to change the base?

Add support for EKS Capability #45326

Conversation

punkwalker commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollback Plan

Changes to Security Controls

Description

Relations

References

Output from Acceptance Testing

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Community Guidelines

Voting for Prioritization

Pull Request Authors

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ewbankkit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

punkwalker commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading